-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stubs for python-cronlog #8917
Conversation
This comment has been minimized.
This comment has been minimized.
a87772f
to
45947b5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added a number of comments and suggested some more precise types. In general, the stubs use the Incomplete
marker unnecessarily too much.
#8472 has some discussion about why we prefer to leave parameters unannotated rather than using Pyright will likely start complaining if you remove some of the typeshed/pyrightconfig.stricter.json Lines 8 to 97 in a1a245b
|
Co-authored-by: Jelle Zijlstra <[email protected]>
42a966b
to
86fcdb2
Compare
86fcdb2
to
44bc57f
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Waygood <[email protected]>
ee3abe5
to
f8651b7
Compare
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
No description provided.