-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SLSTR angle interpolation. #3017
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
==========================================
- Coverage 96.13% 96.11% -0.02%
==========================================
Files 383 383
Lines 55688 55697 +9
==========================================
+ Hits 53534 53535 +1
- Misses 2154 2162 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 13543319156Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting method, thanks for implementing it! How about adding a test or two for it?
This PR adds a new method for interpolating angles from the SLSTR tie grid, which should prevent the unrealistically low and/or high values that sometimes showed up before, primarily in granules near the poles.