Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLSTR angle interpolation. #3017

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Fix rogue space in SLSTR L1b reader.

f770395
Select commit
Loading
Failed to load commit list.
Open

Fix SLSTR angle interpolation. #3017

Fix rogue space in SLSTR L1b reader.
f770395
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 26, 2025 in 28s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
slstr_l1b.py 1 advisory rule 9.84 → 9.54 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method slstr_l1b.py: NCSLSTRAngles.get_dataset

Annotations

Check warning on line 325 in satpy/readers/slstr_l1b.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

NCSLSTRAngles.get_dataset has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis