Handle setting subscriber nameserver to False #159
Conversation
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 95.36% 95.37%
=======================================
Files 13 13
Lines 2652 2700 +48
=======================================
+ Hits 2529 2575 +46
- Misses 123 125 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| It is possible to disable Posttroll Nameserver usage for the incoming | ||
| messages by starting ``satpy_launcher.py`` with command-line arguments | ||
| ``-n False -a tcp://<host>:<port>`` where the host and port point to a | ||
| message publisher. Multiple publisher addresses can be given by supplying | ||
| them with additional ``-a`` switches. |
There was a problem hiding this comment.
Just a question here: Is this the same interface we use in other pytroll modules?
There was a problem hiding this comment.
Internally, yes. All the packages using create_subscriber_from_dict_config() or create_publisher_from_dict_config() are using the same settings, explained here: https://github.com/pytroll/posttroll/blob/main/posttroll/subscriber.py#L437-L438
There was a problem hiding this comment.
ok! but I was actually wondering if the external/command line interface was the same?
There was a problem hiding this comment.
For the incoming messages (subscribers) I found these:
geographic_gatherer.pyuses-n falseand-i tcp://..., where-iis "inbound connection" and means the same as-adoes heresegment_gatherer.pyreads these settings from the config file (usingnameserversandaddressesoption names)
Internally the both use posttroll.subscriber.create_subscriber_from_dict_config(), so given the same combination the nameserver handling will be the same. The names used by Posttroll are addresses and nameserver.
The -a and -n options were present in satpy_launcher.py already before this PR.
There was a problem hiding this comment.
ok, we'll keep them for now then
…m/pnuu/trollflow2 into feature-listener-nameserver-false
It wasn't possible to disable the subscriber nameserver to
False. With this PR, the argument parsing takes care of this. Also, the argument parsing and launching of theRunnerhave now been moved totrollflow2.launcherso we could add tests for them.flake8 trollflow2