-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle setting subscriber nameserver to False #159
Merged
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c5ff2ad
Move startup and argument parsing to trollflow2.launcher module
pnuu ffa8829
Ensure '-n false' sets subscriber nameserver to False
pnuu 699d9d1
Mention how subsciber nameserver can be disabled
pnuu e339da6
Mention the example playlist in documentation
pnuu 7bfb651
Fix log level when launching Trollflow2
pnuu cff7809
Test trollflow2.launcher.launch()
pnuu 3c5b386
Mention possibility for nameserver disabling in argument parser
pnuu 8b3c91b
Merge branch 'main' into feature-listener-nameserver-false
pnuu 95d56a1
Move reading log config to a separate function
pnuu f82c7e0
Merge branch 'feature-listener-nameserver-false' of https://github.co…
pnuu 8389941
Merge branch 'main' into feature-listener-nameserver-false
pnuu ff232fa
Merge branch 'main' into feature-listener-nameserver-false
pnuu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question here: Is this the same interface we use in other pytroll modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internally, yes. All the packages using
create_subscriber_from_dict_config()
orcreate_publisher_from_dict_config()
are using the same settings, explained here: https://github.com/pytroll/posttroll/blob/main/posttroll/subscriber.py#L437-L438There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok! but I was actually wondering if the external/command line interface was the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump @pnuu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the incoming messages (subscribers) I found these:
geographic_gatherer.py
uses-n false
and-i tcp://...
, where-i
is "inbound connection" and means the same as-a
does heresegment_gatherer.py
reads these settings from the config file (usingnameservers
andaddresses
option names)Internally the both use
posttroll.subscriber.create_subscriber_from_dict_config()
, so given the same combination thenameserver
handling will be the same. The names used by Posttroll areaddresses
andnameserver
.The
-a
and-n
options were present insatpy_launcher.py
already before this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we'll keep them for now then