-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/update-safety-schemas-version #624
Conversation
WalkthroughThe pull request updates version requirements for the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
setup.cfg (1)
53-53
: Consider adding an upper bound constraint.While the change to
>=0.0.8
is correct for supporting pyproject.toml, consider adding an upper bound constraint (e.g.,>=0.0.8,<1.0.0
) to prevent potential compatibility issues with future major versions.- safety_schemas>=0.0.8 + safety_schemas>=0.0.8,<1.0.0
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- setup.cfg (1 hunks)
- test_requirements.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- test_requirements.txt
🔇 Additional comments (2)
setup.cfg (2)
53-53
: LGTM! Version update aligns with PR objectives.The version update to
>=0.0.8
correctly addresses the need for pyproject.toml support as mentioned in the PR description.
53-53
: Verify safety_schemas>=0.0.8 availability on PyPI.Let's ensure this version is published and available for users.
✅ Verification successful
Version 0.0.8 of safety_schemas is available on PyPI
The required version safety_schemas>=0.0.8 is published and available on PyPI, ensuring users can successfully install the package with the updated dependency.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if safety_schemas>=0.0.8 exists on PyPI # Expected: The version should be available to prevent installation issues curl -s "https://pypi.org/pypi/safety_schemas/json" | jq -r '.releases | keys[]' | sort -V | grep "0.0.8"Length of output: 109
With the new pyproject.toml support, we now must be using safety-schemas version >0.0.8
Summary by CodeRabbit
safety_schemas
package to ensure access to the latest features and fixes.