Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREP: add vsearch, remove types-genomics and rescript #145

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

lizgehret
Copy link
Member

No description provided.

@nbokulich
Copy link
Member

Hey @lizgehret sorry I think I missed something — I thought that we were just adding RESCRIPt to the amplicon distro, not removing it from shotgun (where it was added for the get-ncbi-genomes action). Why is it being removed, and what is vsearch needed for in the shotgun distro if not for RESCRIPt?

@lizgehret
Copy link
Member Author

Hey @nbokulich sorry for the confusion! I had checked with @gregcaporaso on whether we wanted to keep RESCRIPt in both or just have it in amplicon, and he didn't realize it was already in shotgun so I removed it. I can definitely add it back in though since it's needed for get-ncbi-genomes - sorry about that!

Re: adding vsearch, @colinvwood had reminded us that it should be added - it was originally intended to be in the shotgun distro last release, but it was an oversight on our end that we didn't add it.

@lizgehret
Copy link
Member Author

I'm going to let this Prepare finish just as a proof of concept (to make sure the metapackage solves and all of the unit tests pass) but once this is finished, I'll re-run another one that adds RESCRIPt back in.

@nbokulich
Copy link
Member

Thanks for clarifying @lizgehret ! Sounds good!

@lizgehret lizgehret merged commit 50b56cd into dev Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants