Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #128 AsciiDoc native support #129

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fix #128 AsciiDoc native support #129

merged 2 commits into from
Oct 30, 2024

Conversation

melloware
Copy link
Contributor

Fix #128 AsciiDoc native support

@melloware melloware requested a review from a team as a code owner October 22, 2024 14:13
@mcruzdev
Copy link
Member

Nice @melloware!

@ia3andy
Copy link
Contributor

ia3andy commented Oct 24, 2024

We might need more to this PR as native build is failing again

@ia3andy
Copy link
Contributor

ia3andy commented Oct 24, 2024

Ah ok you didn't merge on ROq part: quarkiverse/quarkus-roq#207

@ia3andy
Copy link
Contributor

ia3andy commented Oct 24, 2024

@mkouba could we merge this and the other and release?

@melloware
Copy link
Contributor Author

yep this fixes Roq i tested yesterday with this fix and Native will pass.

@mkouba
Copy link
Contributor

mkouba commented Oct 24, 2024

@mkouba could we merge this and the other and release?

I had two questions so I'd rather know the answers before we merge this PR ;-).

@ia3andy
Copy link
Contributor

ia3andy commented Oct 24, 2024

@mkouba could we merge this and the other and release?

I had two questions so I'd rather know the answers before we merge this PR ;-).

I don't see your questions?

@ia3andy
Copy link
Contributor

ia3andy commented Oct 24, 2024

You probably didn't submit the review :)

@melloware
Copy link
Contributor Author

I also did a prototype PR of this in Roq to verify it works in Native: quarkiverse/quarkus-roq#207

@mkouba
Copy link
Contributor

mkouba commented Oct 25, 2024

You probably didn't submit the review :)

🤦

@melloware
Copy link
Contributor Author

@mkouba if you prefer I can move this stuff to Roq if you don't want this here? We can handle it there it just felt right to handle it here?

@ia3andy
Copy link
Contributor

ia3andy commented Oct 26, 2024

@mkouba could we solve this?

This is blocking Roq 1.0.0

@mkouba mkouba mentioned this pull request Oct 30, 2024
Merged
@ia3andy
Copy link
Contributor

ia3andy commented Oct 30, 2024

Let's see if the CI passes now, I'll try locally without the dependency indexing

@mkouba mkouba merged commit c74a1f1 into quarkiverse:main Oct 30, 2024
2 checks passed
@melloware melloware deleted the 128-asciidoc branch October 30, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy left review comments

@mkouba mkouba mkouba left review comments

@mcruzdev mcruzdev mcruzdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsciiDoc: Native Support
4 participants
@melloware @mcruzdev @ia3andy @mkouba