-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #28: throw the errors coming from quickwit #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idrissneumann
force-pushed
the
feat_display_qw_errors
branch
from
November 24, 2023 11:01
3af16ad
to
86bb72a
Compare
idrissneumann
force-pushed
the
feat_display_qw_errors
branch
4 times, most recently
from
November 25, 2023 11:49
65a0d33
to
b6bc737
Compare
idrissneumann
force-pushed
the
feat_display_qw_errors
branch
from
November 25, 2023 12:13
b6bc737
to
3b56a94
Compare
At this stage, using : "github.com/grafana/grafana-plugin-sdk-go/experimental/errorsource"
// ...
response := backend.NewQueryDataResponse()
return errorsource.AddErrorToResponse(e.dataQueries[0].RefID, response, err), nil We got a 200 response with empty body: Whereas the error is still logged on the server side: grafana-quickwit-datasource | logger=plugin.quickwit-quickwit-datasource t=2023-11-27T14:57:18.449939435Z level=error msg="Error on multisearch: statusCode = 400, responseBody = {}, queryParam = \"max_concurrent_shard_requests=256\", requestBody = [{\"query\":{\"bool\":{\"filter\":{\"range\":{\"timestamp\":{\"gte\":\"2023-11-27T02:57:17.995Z\",\"lte\":\"2023-11-27T14:57:17.995Z\"}}}}},\"size\":100,\"sort\":[{\"timestamp\":{\"order\":\"desc\"}},{\"_doc\":{\"order\":\"desc\"}}]}]" Rollback for now, you can see the diff here: 9ee64fe |
…dling" This reverts commit 9ee64fe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.