Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Log context exploration support #45

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Improve Log context exploration support #45

merged 6 commits into from
Feb 6, 2024

Conversation

ddelemeny
Copy link
Collaborator

@ddelemeny ddelemeny commented Jan 19, 2024 •
edited
Loading

Notable Changes :

  • Refactor LogContext implementation into a more self-contained provider class.
  • Use the origin query to fetch log context
  • Experimental : Add a full-text query editor ( Monaco CodeMirror6)
  • Experimental : Autocomplete fields and values
  • Experimental : Contextual query builder UI

UI Screenshots

quickwit-grafana-logcontext-screencast

Known caveats

  • The LogContext API does not seem to provide support for multiple origin queries, therefore the provided context information may be erroneous wrt such a use case. Investigate upstream : hardcoded first query used in getLogContext
  • The query builder sidebar is limited, only appends filters to the query for now

@ddelemeny ddelemeny force-pushed the ddelemeny-logcontext branch from c6b4580 to 48e06a1 Compare January 25, 2024 15:54
@ddelemeny ddelemeny requested a review from fmassot January 25, 2024 16:45
@ddelemeny ddelemeny marked this pull request as ready for review January 25, 2024 16:53
@ddelemeny ddelemeny marked this pull request as draft February 5, 2024 16:39
@ddelemeny ddelemeny force-pushed the ddelemeny-logcontext branch from 3c390ab to 32996df Compare February 5, 2024 18:45
@ddelemeny ddelemeny force-pushed the ddelemeny-logcontext branch 4 times, most recently from 7c627d9 to be405dd Compare February 5, 2024 20:07
@ddelemeny ddelemeny force-pushed the ddelemeny-logcontext branch from be405dd to dd93765 Compare February 5, 2024 20:09
@ddelemeny ddelemeny force-pushed the ddelemeny-logcontext branch from dd93765 to 7183f8c Compare February 5, 2024 20:25
@ddelemeny ddelemeny marked this pull request as ready for review February 5, 2024 23:12
@ddelemeny ddelemeny linked an issue Feb 5, 2024 that may be closed by this pull request
Improve context feature #42
Closed
fmassot
fmassot reviewed Feb 6, 2024
View reviewed changes
src/LogContext/components/LogContextQueryBuilderSidebar.tsx
const excludedFields = [
'_source',
'sort',
'attributes',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to be an issue as this works only for otel indexes.

Can you open an issue on that?

fmassot
fmassot reviewed Feb 6, 2024
View reviewed changes
src/datasource.ts

// NOTE : deprecated since grafana-data 10.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you open an issue on this? we should also upgrade all packages to 10.3 and docker image too.

@ddelemeny ddelemeny merged commit 55f88c7 into main Feb 6, 2024
2 checks passed
@ddelemeny ddelemeny linked an issue Feb 6, 2024 that may be closed by this pull request
Add autocompletion in the search query editor #19
Closed
@ddelemeny ddelemeny deleted the ddelemeny-logcontext branch February 8, 2024 03:29
@ddelemeny ddelemeny mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve context feature Add autocompletion in the search query editor
2 participants
@ddelemeny @fmassot