Improve IndexWriter customisation via builder
#2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChillFish8
force-pushed
the
chillfish8/poc-index-writer-options
branch
from
2c34a0d to
0e3a658
Compare
ChillFish8
force-pushed
the
chillfish8/poc-index-writer-options
branch
from
0e3a658 to
2269845
Compare
fulmicoton
reviewed
Dec 31, 2024
fulmicoton
reviewed
Dec 31, 2024
ChillFish8
changed the title
IndexWriter customisation via builderIndexWriter customisation via builder
fulmicoton
approved these changes
Jan 2, 2025
fulmicoton
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently been hacking the index writer apart to do some mildly questionable thing, as part of that I found myself wanting to customise some more parts of the writer but adding another method with more config options was starting to get unwieldy. Especially since #2535
This PR adds a builder notibly
IndexWriterOptionswhich improves the ergonomics of configuring the writer.However, I did also make the options another method to avoid making it a huge breaking change, but maybe a breaking change of the create API fine.
Also sorry, I accidentally wrapped some of the work I did around deferring indexer threads being spawned until required, will remove at a later point.