Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase image opening speed #18

Merged
merged 17 commits into from
Apr 11, 2024
Merged

Increase image opening speed #18

merged 17 commits into from
Apr 11, 2024

Conversation

Rylern
Copy link
Collaborator

@Rylern Rylern commented Apr 5, 2024

@petebankhead could you review the ObjectPool class? It's a generic class to create a pool of objects. It could be integrated to QuPath as it can be useful outside of the OMERO extension (for example to simplify the BioFormats image server). You can see an example of how it is used in the IceReader class.

@petebankhead
Copy link
Member

I really like the ObjectPool idea - I agree it should be somewhere reusable, and it could help simplify the Bio-Formats server implementation.

Ultimately, what do you think of us creating a qupath-commons permissively-licensed module for non-ui code, similar to qupath-fxtras?

Eventually we should move other data-structures and interfaces there, to promote reusability with different open-source licenses.

@Rylern
Copy link
Collaborator Author

Rylern commented Apr 9, 2024

Ultimately, what do you think of us creating a qupath-commons permissively-licensed module for non-ui code, similar to qupath-fxtras?

Yes, I think it's a good idea

@Rylern
Copy link
Collaborator Author

Rylern commented Apr 11, 2024

I will merge this pull request now so that I can respond to #1. I'll update this extension when we create the qupath-commons project.

@Rylern Rylern merged commit 2122b65 into main Apr 11, 2024
@Rylern Rylern deleted the increase-image-opening-speed branch April 11, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants