Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first version of rabi.qmd #14

Merged
merged 11 commits into from
Jan 20, 2025
Merged

Add first version of rabi.qmd #14

merged 11 commits into from
Jan 20, 2025

Conversation

TendonFFF
Copy link
Contributor

Checklist

Thank you for contributing to Tutorials for Quantum Toolbox in Julia! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • The (last update) date were modified for new or updated tutorials.
  • All tutorials were able to render locally by running: make render.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

As title

@TendonFFF TendonFFF marked this pull request as ready for review January 14, 2025 12:23
ytdHuang
ytdHuang reviewed Jan 14, 2025
View reviewed changes
QuantumToolbox.jl/toc.md Outdated Show resolved Hide resolved
@TendonFFF TendonFFF requested a review from ytdHuang January 14, 2025 14:38
ytdHuang
ytdHuang reviewed Jan 14, 2025
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
@TendonFFF TendonFFF requested a review from ytdHuang January 15, 2025 02:51
ytdHuang
ytdHuang requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more things need to be addressed

ytdHuang
ytdHuang requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tutorial you demonstrated is not "vacuum" Rabi oscillation

@ytdHuang ytdHuang self-requested a review January 17, 2025 01:16
ytdHuang
ytdHuang requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay
a few more minor changes, and then I think the tutorial is ready

QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
@TendonFFF TendonFFF requested a review from ytdHuang January 17, 2025 04:39
albertomercurio
albertomercurio reviewed Jan 19, 2025
View reviewed changes
Copy link
Member

@albertomercurio albertomercurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall you did a good job. I have just made some suggestion about the grammar.

QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
QuantumToolbox.jl/time_evolution/rabi.qmd Outdated Show resolved Hide resolved
@ytdHuang ytdHuang merged commit 328908b into qutip:main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertomercurio albertomercurio albertomercurio left review comments

@ytdHuang ytdHuang ytdHuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TendonFFF @ytdHuang @albertomercurio