replace custom native review module with expo-store-review

[maxbbb]

Fixes APP-2038

What changed (plus any additional context for devs)

Fixes the app not being able to receive touches after the SKStoreReviewController was shown on iOS.

The app would not be able to receive any touches until force closed regardless of if the user selected "Not Now" or rated the app once the SKStoreReviewController was shown.

expo-store-review was added to replace custom native module implementation, but that did not fix the issue.
The addition of expo-store-review was kept regardless due to the custom native module implementations being 5 years old and including some method swizzling and arbitrary timeouts to get around issues that no longer exist.

The issue was related to this extension in the Extensions.swift file

extension UIView { 
  open override var canBecomeFirstResponder: Bool {
      return true
  }
}

This code was added in a 5 year old PR (#509) for improving performance of a native list component that is no longer used, so it should be safe to remove.

This issue CocoaDebug/CocoaDebug/issues/143 has more information on why this happens

Screen recordings / screenshots

RPReplay_Final1731728558.MP4

What to test

• Go to settings
• Click "Review Rainbow"
• Click "Yes"
• Click "Not Now", and the app should not freeze.

[linear]

APP-2038 [iOS] App Store rating alert breaks the app

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	None	0	29.9 kB	brentvatne

View full report↗︎

[brunobar79]

LGTM!

Added @ibrahimtaveras00 as a reviewer so he can check on android before merging

[ibrahimtaveras00]

Not sure if this is because I already reviewed the apps on both stores or not, but when I tap yes on my iPhone on testflight or on my test android nothing happens.

Android seen here:
https://github.com/user-attachments/assets/68ee7627-9ebd-4a59-8ac6-51751c7a1bc6

iOS seen here:
https://github.com/user-attachments/assets/7beeeff1-c3c5-4d08-a49b-8d51f800b079

Tested on iOS on Testflight version 1.9.47 (3)
Tested on Android on release apk

Another way to get the review to pop up:

• start the app in a clean state
• create a new wallet
• tap send button then add a contact

or

• start the app in a clean state
• create a new wallet
• create another new wallet
• now watch a wallet

[maxbbb]

On iOS the review request cannot be shown in Testflight builds. I'm assuming there is something similar on Android but I haven't looked into it.

You can get directly to the review request by going to Settings -> Review Rainbow

[ibrahimtaveras00]

I just checked prod on playstore and same bug happens there, cc @brunobar79

Screen.Recording.2024-11-21.at.12.51.51.PM.mov

[brunobar79]

Not sure if this is because I already reviewed the apps on both stores or no

@ibrahimtaveras00 Can you try with a different google account before we assume it's a bug?

[ibrahimtaveras00]

All good here on both OS's, QA Passed 👍🏽

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ Error: Request review flow failed <global>(src/utils/reviewAlert) View Issue

_{Did you find this useful? React with a 👍 or 👎}