Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace custom native review module with expo-store-review #6268

Merged
merged 3 commits into from
Nov 21, 2024
Merged

replace custom native review module with expo-store-review #6268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2aee989
replace custom native review module with expo-store-review
maxbbb Nov 16, 2024
6cf267f
remove custom store review native modules
maxbbb Nov 18, 2024
78510f7
Merge branch 'develop' into @kane/APP-2038
ibrahimtaveras00 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions android/app/src/main/java/me/rainbow/MainApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import me.rainbow.NativeModules.Haptics.RNHapticsPackage
import me.rainbow.NativeModules.Internals.InternalPackage
import me.rainbow.NativeModules.RNBackHandler.RNBackHandlerPackage
import me.rainbow.NativeModules.RNBip39.RNBip39Package
import me.rainbow.NativeModules.RNReview.RNReviewPackage
import me.rainbow.NativeModules.RNStartTime.RNStartTimePackage
import me.rainbow.NativeModules.RNTextAnimatorPackage.RNTextAnimatorPackage
import me.rainbow.NativeModules.RNZoomableButton.RNZoomableButtonPackage
Expand All @@ -36,7 +35,6 @@ class MainApplication : Application(), ReactApplication {
val packages: MutableList<ReactPackage> = PackageList(this).packages
// Packages that cannot be autolinked yet can be added manually here, for example:
packages.add(RNBip39Package())
packages.add(RNReviewPackage())
packages.add(SystemNavigationBarPackage())
packages.add(RNBackHandlerPackage())
packages.add(RNTextAnimatorPackage())
Expand Down
54 changes: 0 additions & 54 deletions android/app/src/main/java/me/rainbow/NativeModules/RNReview/RNReviewModule.java
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions android/app/src/main/java/me/rainbow/NativeModules/RNReview/RNReviewPackage.java
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions ios/Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ extension UIScreen {

extension UIView {

open override var canBecomeFirstResponder: Bool {
return true
}

static func fromNib<T: UIView>() -> T {
return Bundle(for: T.self).loadNibNamed(String(describing: T.self), owner: nil, options: nil)![0] as! T
}
Expand Down
6 changes: 6 additions & 0 deletions ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- ExpoStoreReview (7.0.2):
- ExpoModulesCore
- FasterImage (1.6.2):
- FasterImage/Nuke (= 1.6.2)
- FasterImage/NukeUI (= 1.6.2)
Expand Down Expand Up @@ -1916,6 +1918,7 @@ DEPENDENCIES:
- ExpoFont (from `../node_modules/expo-font/ios`)
- ExpoKeepAwake (from `../node_modules/expo-keep-awake/ios`)
- ExpoModulesCore (from `../node_modules/expo-modules-core`)
- ExpoStoreReview (from `../node_modules/expo-store-review/ios`)
- "FasterImage (from `../node_modules/@candlefinance/faster-image`)"
- FBLazyVector (from `../node_modules/react-native/Libraries/FBLazyVector`)
- Firebase
Expand Down Expand Up @@ -2119,6 +2122,8 @@ EXTERNAL SOURCES:
:path: "../node_modules/expo-keep-awake/ios"
ExpoModulesCore:
:path: "../node_modules/expo-modules-core"
ExpoStoreReview:
:path: "../node_modules/expo-store-review/ios"
FasterImage:
:path: "../node_modules/@candlefinance/faster-image"
FBLazyVector:
Expand Down Expand Up @@ -2393,6 +2398,7 @@ SPEC CHECKSUMS:
ExpoFont: 00756e6c796d8f7ee8d211e29c8b619e75cbf238
ExpoKeepAwake: 3b8815d9dd1d419ee474df004021c69fdd316d08
ExpoModulesCore: f30a203ff1863bab3dd9f4421e7fc1564797f18a
ExpoStoreReview: 15f9a636b62ff00bb21cbe9a9fe22f0239da4481
FasterImage: af05a76f042ca3654c962b658fdb01cb4d31caee
FBLazyVector: 7e977dd099937dc5458851233141583abba49ff2
Firebase: 26b040b20866a55f55eb3611b9fcf3ae64816b86
Expand Down
Loading
Loading