drm/vc4: hvs: Defer updating the enable_bg_fill until vblank #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The register to enable/disable background fill was being set from atomic flush, however that will be applied immediately and can be a while before the vblank. If it was required for the current frame but not for the next one, that can result in corruption for part of the current frame. Store the state in vc4_hvs, and update it on vblank. Signed-off-by: Dave Stevenson <[email protected]>
|
Thanks! Confirmed that this fixes the issue on my Pi5, and I don't see any other issues with background fill being enabled/disabled. Do you reckon this wants separately testing on D0? |
|
D0 should make no difference here, although I have a 2GB Pi5 with D0 here if you want to do the quick test. |
|
Happy to leave it if there's no particular D0 changes around this, it'll be a while before any software in the wild is actually using this. |
popcornmix
approved these changes
Nov 18, 2024
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 20, 2024
See: raspberrypi/linux#6463 kernel: dtoverlays: enable SPI CS active-high See: raspberrypi/linux#6477 kernel: drivers: media: pci: Update Hailo accelerator device driver to v4.19 See: raspberrypi/linux#6478 kernel: misc: rp1-pio: Add FIFO-related methods See: raspberrypi/linux#6470
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 20, 2024
See: raspberrypi/linux#6463 kernel: dtoverlays: enable SPI CS active-high See: raspberrypi/linux#6477 kernel: drivers: media: pci: Update Hailo accelerator device driver to v4.19 See: raspberrypi/linux#6478 kernel: misc: rp1-pio: Add FIFO-related methods See: raspberrypi/linux#6470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The register to enable/disable background fill was being set from atomic flush, however that will be applied immediately and can be a while before the vblank. If it was required for the current frame but not for the next one, that can result in corruption for part of the current frame.
Store the state in vc4_hvs, and update it on vblank.
@cillian64 for test.