ScalerCrops #1134
Merged
ScalerCrops #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this change and new functionality is only applicable on Pi 5. The stream configuration dictionary now has a "preserve_ar" key that when set to True, will preserve the aspect ratio of the output by cropping the sensor image appropriately. If set to False, the full field of view of the sensor image is used to scale to the output resolution. This happens separately for the main and lores streams. The default behaviour of this flag is as follows: - For the main stream, it is set to True. This preserves existing behaviour. - For the lowres stream, it is set to False, which then makes the lowres stream crop follows the crop of the main stream. Again, this preservies existing behaviour, also matching VC4. Signed-off-by: Naushir Patuck <[email protected]>
Add this control to the ignore list. Signed-off-by: Naushir Patuck <[email protected]>
Signed-off-by: Naushir Patuck <[email protected]>
Stops us being at the mercy of the random darkness in the server room. Signed-off-by: David Plowman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1087