Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalerCrops #1134

Merged
merged 4 commits into from
Oct 17, 2024
Merged

ScalerCrops #1134

merged 4 commits into from
Oct 17, 2024

Commits on Oct 17, 2024

  1. picamera2: Add support for ScalerCrops controls 

    Note that this change and new functionality is only applicable on Pi 5.

The stream configuration dictionary now has a "preserve_ar" key that
when set to True, will preserve the aspect ratio of the output by
cropping the sensor image appropriately. If set to False, the full
field of view of the sensor image is used to scale to the output
resolution. This happens separately for the main and lores streams.

The default behaviour of this flag is as follows:

- For the main stream, it is set to True. This preserves existing
  behaviour.

- For the lowres stream, it is set to False, which then makes the lowres
  stream crop follows the crop of the main stream. Again, this
  preservies existing behaviour, also matching VC4.

Signed-off-by: Naushir Patuck <[email protected]>
    @naushir @davidplowman
    naushir authored and davidplowman committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6de23fa View commit details
    Browse the repository at this point in the history

  2. app_full: Add support for ScalerCrops control 

    Add this control to the ignore list.

Signed-off-by: Naushir Patuck <[email protected]>
    @naushir @davidplowman
    naushir authored and davidplowman committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a46fb48 View commit details
    Browse the repository at this point in the history

  3. tests: Add a crop test with the new "perserve_ar" config param 

    Signed-off-by: Naushir Patuck <[email protected]>
    @naushir @davidplowman
    naushir authored and davidplowman committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    adbfaa7 View commit details
    Browse the repository at this point in the history

  4. Update runners with ASSET_DIR to pick up canned video for encoder tests 

    Stops us being at the mercy of the random darkness in the server room.

Signed-off-by: David Plowman <[email protected]>
    @davidplowman
    davidplowman committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    aef24f7 View commit details
    Browse the repository at this point in the history