-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename chunks kwarg to partition_chunks into open_datatree method #37
Conversation
@JSKenyon @landmanbester @o-smirnov Would you mind reviewing this general logic behind this change? The reasoning is explained further in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look controversial to me, and it is better to change these things sooner rather than later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, seems uncontroversial and good to do this now rather than later
Thanks for the review. |
The
chunks
keyword argument in open_dataset and open_datatree is reserved. In the case ofopen_datatree
it is simply passed through to theopen_dataset
method.Previously, xarray-ms allowed a custom per-partition chunking schema to be passed via the
chunks
kwarg inMSv2PartitionEntryPoint.open_datatree
. For e.g.While
MSv2PartitionEntryPoint.open_datatree
understands this chunking schema, other storage backends do not so there is potential for undefined behaviour.This PR moves this functionality from
chunks
kwarg to the newpartition_chunks
kwarg which is only understood byMSv2PartitionEntryPoint.open_datatree
. This separatesxarray-ms
's custom chunking behaviour from xarray's default chunking behaviour.doc/source/changelog.rst
.📚 Documentation preview 📚: https://xarray-ms--37.org.readthedocs.build/en/37/