fix(Tile): fix icon y position when ProgressBar is empty #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Execution Passed. |
soumyaloka
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw and
slhay28
as code owners
ImCoolNowRight
approved these changes
Oct 9, 2023
joshhowenstine
approved these changes
Oct 11, 2023
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 12, 2023
# [@lightningjs/ui-components-v2.14.2](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.14.1...@lightningjs/ui-components-v2.14.2) (2023-10-12) ### Bug Fixes * **FocusManager:** call super in _focus and _unfocus without smoothing ([#385](#385)) ([854e891](854e891)) * **MetadataBase:** rename subtitle property, tag, and style to details ([#384](#384)) ([fdd7bfe](fdd7bfe)) * **Tile:** fix icon y position when ProgressBar is empty ([#382](#382)) ([69e3528](69e3528))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, updated icon's vertical position when progressbar is empty and also added _updateIcon() in the _metadataLoaded() method to render correctly when metadata is removed.
Testing
Set the progress in progressBar to 0 and verify if the icon's y position is correctly displayed above the Tile.
Automation
Checklist