Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tile): fix icon y position when ProgressBar is empty #382

Merged
merged 36 commits into from
Oct 11, 2023
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
5ec1c7f
feat: update input TS file
soumyaloka Aug 3, 2023
69202b3
fix: revert changes
soumyaloka Aug 3, 2023
ff627d4
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 3, 2023
2764ee9
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 7, 2023
4d57eb0
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 8, 2023
d4823f4
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 10, 2023
8b424b9
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 11, 2023
a3b4a0d
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 11, 2023
b9f864a
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 14, 2023
ee96d6d
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 15, 2023
5cd048e
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 15, 2023
ef56324
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 15, 2023
a47c2e1
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 15, 2023
19b10c8
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 15, 2023
4f52272
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 15, 2023
a4cb034
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 16, 2023
3cccef0
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 22, 2023
ca43d9e
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 22, 2023
331d0d1
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 23, 2023
d2f280f
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 23, 2023
faa2ec3
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 25, 2023
76233f6
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Aug 30, 2023
6ed204f
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 6, 2023
3269a8c
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 8, 2023
ef77677
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 13, 2023
1f66bd7
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 13, 2023
9010b1c
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 13, 2023
df8a1a7
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 14, 2023
2a653db
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 20, 2023
b868973
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 26, 2023
d633871
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 27, 2023
2c3cc52
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 27, 2023
1cfea22
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Sep 28, 2023
43b75ef
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Oct 4, 2023
f0311c5
Merge branch 'develop' of github.com:rdkcentral/Lightning-UI-Componen…
soumyaloka Oct 6, 2023
afa99f1
fix: update icon y position when progressbar is empty
soumyaloka Oct 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export default class Tile extends Surface {
} else {
return this._progressBarY
? this._progressBarY - this.style.paddingYBetweenContent
: this._h + this.style.paddingY;
: this._h - this.style.paddingY;
}
}
/* ------------------------------ Artwork ------------------------------ */
Expand Down Expand Up @@ -612,6 +612,7 @@ export default class Tile extends Surface {

_metadataLoaded() {
this._animateMetadata();
this._updateIcon();
// Send event to columns/rows that the height has been updated since metadata will be displayed below the Tile
if (!this._isInsetMetadata) {
this.fireAncestors('$itemChanged');
Expand Down