Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links in Hindi JSX documentation #322

Closed
wants to merge 1 commit into from

Conversation

mohan-marwari
Copy link
Contributor

Fixed broken links in Hindi JSX documentation

I have updated two broken links in the Hindi JSX documentation that were pointing to placeholder URLs (TODO). The changes are as follows:

  1. React Fragment Link:

    • Previous:
      [React fragment](TODO)
    • Updated:
      [React fragment](https://react.dev/reference/react/Fragment)
  2. React DOM Attributes Link:

    • Previous:
      [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](TODO)
    • Updated:
      [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](https://react.dev/reference/react-dom/components/common)

These fixes ensure that users are directed to the correct pages for additional information.

Let me know if further changes are required. Thank you! 😊

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for this.

I have added a change request for a minor change once those are done we can get this merged.

@@ -166,7 +166,7 @@ img { height: 90px }
</>
```

इस खाली टैग को *[React fragment](TODO)* कहा जाता है। React fragments आपको ब्राउज़र HTML ट्री में कोई निशान छोड़े बिना चीजों को ग्रुप करने देते हैं।
इस खाली टैग को *[React fragment](https://react.dev/reference/react/Fragment)* कहा जाता है। React fragments आपको ब्राउज़र HTML ट्री में कोई निशान छोड़े बिना चीजों को ग्रुप करने देते हैं।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the link similar to we have in english version of the doc? https://github.com/reactjs/react.dev/blob/main/src/content/learn/writing-markup-with-jsx.md?plain=1#L172

@@ -211,7 +211,7 @@ JSX जावास्क्रिप्ट में बदल जाता ह
/>
```

आप [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](TODO). यदि आप एक गलत पाते हैं, तो चिंता न करें React संभावित सुधार के साथ एक संदेश [ब्राउज़र कंसोल](https://developer.mozilla.org/docs/Tools/Browser_Console) पर प्रिंट करेगी।
आप [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](https://react.dev/reference/react-dom/components/common). यदि आप एक गलत पाते हैं, तो चिंता न करें React संभावित सुधार के साथ एक संदेश [ब्राउज़र कंसोल](https://developer.mozilla.org/docs/Tools/Browser_Console) पर प्रिंट करेगी।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@mohan-marwari mohan-marwari Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out! 🙌

Updated links to use relative URLs as in the English documentation. #323

I have updated the links to use relative URLs as per your suggestion. Let me know if there's anything else that needs to be adjusted. 😊

@arshadkazmi42
Copy link
Member

You could have just pushed a new commit to this PR itself in place of creating a new pull request.

Anyways I will close this pull request.

@mohan-marwari
Copy link
Contributor Author

Thank you, @arshadkazmi42.

I am currently in the learning phase, so by mistake, a new pull request was created. I will make sure to be more careful next time.

Again, thank you for merging my pull request. 😊

@arshadkazmi42
Copy link
Member

@mohan-marwari OpenSource community is really good and people are there for helping new contributors. You can always ask for help.

I have been to the stage you are at and have received really good help and guidance during my early contributions.

Also feel free to check open issues of the repository, we have some translation work pending and those are always good place to start for opensource journey.

@mohan-marwari
Copy link
Contributor Author

Ok Sir 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants