Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links in Hindi JSX documentation #322

Closed
wants to merge 1 commit into from
Closed

Fixed broken links in Hindi JSX documentation #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/content/learn/writing-markup-with-jsx.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ img { height: 90px }
</>
```

इस खाली टैग को *[React fragment](TODO)* कहा जाता है। React fragments आपको ब्राउज़र HTML ट्री में कोई निशान छोड़े बिना चीजों को ग्रुप करने देते हैं।
इस खाली टैग को *[React fragment](https://react.dev/reference/react/Fragment)* कहा जाता है। React fragments आपको ब्राउज़र HTML ट्री में कोई निशान छोड़े बिना चीजों को ग्रुप करने देते हैं।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the link similar to we have in english version of the doc? https://github.com/reactjs/react.dev/blob/main/src/content/learn/writing-markup-with-jsx.md?plain=1#L172


<DeepDive>

Expand Down Expand Up @@ -211,7 +211,7 @@ JSX जावास्क्रिप्ट में बदल जाता ह
/>
```

आप [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](TODO). यदि आप एक गलत पाते हैं, तो चिंता न करें React संभावित सुधार के साथ एक संदेश [ब्राउज़र कंसोल](https://developer.mozilla.org/docs/Tools/Browser_Console) पर प्रिंट करेगी।
आप [इन सभी ऐट्रिब्यूट्स को React DOM एलिमेंट्स में पा सकते हैं](https://react.dev/reference/react-dom/components/common). यदि आप एक गलत पाते हैं, तो चिंता न करें React संभावित सुधार के साथ एक संदेश [ब्राउज़र कंसोल](https://developer.mozilla.org/docs/Tools/Browser_Console) पर प्रिंट करेगी।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for here, update the link similar to english version https://github.com/reactjs/react.dev/blob/main/src/content/learn/writing-markup-with-jsx.md?plain=1#L217

Copy link
Contributor Author

@mohan-marwari mohan-marwari Jan 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out! 🙌

Updated links to use relative URLs as in the English documentation. #323

I have updated the links to use relative URLs as per your suggestion. Let me know if there's anything else that needs to be adjusted. 😊


<Pitfall>

Expand Down Expand Up @@ -345,4 +345,4 @@ export default function Bio() {

</Solution>

</Challenges>
</Challenges>