feat: more examples for request/response pairs #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Can you clone these same changes to the .yaml counterparts? To do that I usually just copy-paste the JSON into https://www.bairesdev.com/tools/json2yaml/ and remove the --- header that that thing adds to the top.
It's nice that the YAML and JSON versions of these examples are identical.
|
@erunion fixed! thanks for flagging i missed that |
erunion
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Enhancing a couple existing definitions (
3.0/json/readme-extensions.json,3.0/json/request-examples.json) so we have a variety of test cases for request/response example pair support.🧬 QA & Testing
Do these examples validate and seem sound? I synced them to this test project if you want to give them a whirl:
https://kanad-rdme.readme.io/reference/x-readme_code-samples
https://kanad-rdme.readme.io/reference/get_parameterexamples-param1-param2