-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new platform installation method of AAP 2.5 on OpenShift #261
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is at least one change that needs to happen, I don't have OCP to test this so I will wait for someone who does to review and approve or not
galaxy.yml
Outdated
@@ -1,7 +1,7 @@ | |||
--- | |||
namespace: infra | |||
name: aap_utilities | |||
version: 2.5.2-devel | |||
version: 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djdanielsson I thought so too, but the pre-commit tests seemed to be flagging that as an issue? I'll change it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not like the devel but we want to keep that because of how we have stuff working if pre-commit doesn't like it then ignore it
I'm planning on reviewing and testing, I'll should be able to get to it in the next day or two. |
What does this PR do?
This PR modifies the aap_ocp_install role to support the new platform installation method introduced to the AAP operator in AAP 2.5. It is backward
How should this be tested?
Requires an OpenShift cluster with appropriate credentials, then run:
with configuration as specified in the README and vars files defined in the role.
Once complete, installation can be validated by accessing AAP via the quick links toolbar menu option.
Is there a relevant Issue open for this?
#260
resolves #260
Other Relevant info, PRs, etc
None