-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new platform installation method of AAP 2.5 on OpenShift #261
Open
derekwaters
wants to merge
19
commits into
redhat-cop:devel
Choose a base branch
from
derekwaters:aap-2.5-install
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f4030c6
Add EDA deployment on OCP
42322b0
Update documentation for role change
derekwaters 792b899
Additional checks for EDA variables, and ability to use custom EDA na…
derekwaters e28938c
Merge branch 'devel' into add_eda_install_on_ocp
derekwaters 00064d7
Correct linting formatting errors
derekwaters 789df97
Add endline on changelog fragment
derekwaters 81539a8
Merge branch 'devel' into add_eda_install_on_ocp
branic 594f02d
Modifications to support the new OCP deployment method for AAP 2.5
4aab621
Template fixes identified during testing
e750004
Make the AAP OCP Deployment backward compatible with pre AAP2.5
421f650
Restore missing files
acf412e
Ensure Hub settings are correct
6467bbd
Merge remote-tracking branch 'origin/devel' into aap-2.5-install
e1b9439
Update documentation for OCP Installation AAP 2.5+
09bc565
Corrected trailing whitespace and line feed errors
1051592
Remove duplication in yml file
de251f9
Pre-commit fixes (EOF and github-actions-bot changes)
derekwaters c6b4e08
Fix Jinja templating errors
derekwaters 61d0efb
Revert galaxy version definition
derekwaters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djdanielsson I thought so too, but the pre-commit tests seemed to be flagging that as an issue? I'll change it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not like the devel but we want to keep that because of how we have stuff working if pre-commit doesn't like it then ignore it