Feat rueidiscompat redisearch #676
Conversation
…INDEXEMPTY, INDEXMISSING options
…rchRESP3 and compat-redisearch
unknowntpo
force-pushed
the
feat-rueidiscompat-redisearch
branch
from
9e209e6
to
9320786
Compare
message.go
Outdated
| func (r RedisResult) IsMap() bool { | ||
| return r.val.IsMap() | ||
| } | ||
|
|
||
| // IsArray delegates to RedisMessage.IsArray | ||
| func (r RedisResult) IsArray() bool { | ||
| return r.val.IsArray() | ||
| } |
There was a problem hiding this comment.
| func (r RedisResult) IsMap() bool { | |
| return r.val.IsMap() | |
| } | |
| // IsArray delegates to RedisMessage.IsArray | |
| func (r RedisResult) IsArray() bool { | |
| return r.val.IsArray() | |
| } | |
| func (r RedisResult) isMap() bool { | |
| return r.val.IsMap() | |
| } | |
| // IsArray delegates to RedisMessage.IsArray | |
| func (r RedisResult) isArray() bool { | |
| return r.val.IsArray() | |
| } |
Can we make these 2 methods private first? I am concerned about making these direct delegations to r.val as public APIs. I think we should at least ask users to check the r.err first.
There was a problem hiding this comment.
But if we make IsMap private, functions in command.go can not access it,
I think we could check if any error exists, then delegate to r.val.IsMap.
func (r RedisResult) IsMap() bool {
if r.err != nil {
panic(fmt.Errorf("RedisResult has error: %w, please check the error before calling RedisResult.IsMap", r.err))
}
return r.val.IsMap()
}
There was a problem hiding this comment.
UPDATE: I'll use res.ToMessage() to get underlying message first, then do the IsMap, IsArray check.
rueidiscompat/util.go
Outdated
| func Sleep(ctx context.Context, dur time.Duration) error { | ||
| t := time.NewTimer(dur) | ||
| defer t.Stop() | ||
|
|
||
| select { | ||
| case <-t.C: | ||
| return nil | ||
| case <-ctx.Done(): | ||
| return ctx.Err() | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we remove unused functions in this file?
message.go
Outdated
| @@ -456,7 +456,7 @@ func (r RedisResult) ToMap() (v map[string]RedisMessage, err error) { | |||
| if r.err != nil { | |||
| err = r.err | |||
| } else { | |||
| v, err = r.val.ToMap() | |||
| v, err = r.val.AsMap() | |||
There was a problem hiding this comment.
Why do we need this change? I think we already have an AsMap delegation.
There was a problem hiding this comment.
This is accidentally committed, I've reverted it.
unknowntpo
force-pushed
the
feat-rueidiscompat-redisearch
branch
from
afb8492
to
ec1b389
Compare
Changes and cautions:
compat-redisearchservice for testingRediSearchwithRESP2INDEXEMPTY,INDEXMISSING,WITHCOUNT,ADDSCORESGEOSHAPEWITHCOUNTSUMMARIZEoptionWITHCOUNT