Handle upstream issue milestone of None
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the crash from
2025-01-27 03:02:13,506, it appears that our defense against missing milestone values in upstream issues is not quite sufficient: apparently, the"milestone"key can be present in the upstream issue with a value ofNone, so the trick of specifying a default value in theget()call is not sufficient.This change applies the default both in the case where the key does not exist and the case where the corresponding value is false-y (i.e.,
Noneor any "empty" value).This change also includes a fix for a Black objection. Black recently released v25 which the CI's Tox now uses, and with it came a new demand.