Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle upstream issue milestone of None #283

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Handle upstream issue milestone of None #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cc6c5b
Handle milestone of 'None'
webbnh Jan 30, 2025
d657e1a
Fix a Black objection
webbnh Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sync2jira/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110.15.0 USA
#
# Authors: Ralph Bean <[email protected]>
""" Sync GitHub issues to a jira instance, via fedmsg.
"""Sync GitHub issues to a jira instance, via fedmsg.

Run with systemd, please.
"""
Expand Down
2 changes: 1 addition & 1 deletion sync2jira/upstream_issue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def handle_github_message(msg, config, pr_filter=True):
return None
elif key == "milestone":
# special handling for milestone: use the number
milestone = issue.get(key, {})
milestone = issue.get(key) or {} # Key might exist with value `None`
actual = milestone.get("number")
if expected != actual:
log.debug("Milestone %s not set on issue: %s", expected, upstream)
Expand Down