Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add more eslint (closes #1) #258

Merged
merged 1 commit into from
Aug 20, 2024
Merged

chore: add more eslint (closes #1) #258

merged 1 commit into from
Aug 20, 2024

Conversation

jackyzha0
Copy link
Member

Why

  • consistent style good

What changed

  • add @stylistic

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 requested a review from a team as a code owner August 20, 2024 22:01
@jackyzha0 jackyzha0 requested review from Monkatraz and removed request for a team August 20, 2024 22:01
Monkatraz
Monkatraz approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Monkatraz Monkatraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loont

@jackyzha0 jackyzha0 merged commit 32bc3ee into main Aug 20, 2024
4 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/add-stylitic branch August 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkatraz Monkatraz Monkatraz approved these changes

@masad-frost masad-frost masad-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackyzha0 @masad-frost @Monkatraz