fix: Send a close stream message when the stream input ends
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
approved these changes
Dec 13, 2023
lhchavez
force-pushed
the
lh-fix-dont-require-all-messages-to-contain-proc-info
branch
2 times, most recently
from
0644b6b to
189b26c
Compare
Base automatically changed from
lh-fix-dont-require-all-messages-to-contain-proc-info
to
main
December 13, 2023 19:19
We currently don't send one of these messages when the `stream` input ends, so the server can't know that the client is done! This change now correctly sends the end-of-stream message.
lhchavez
force-pushed
the
lh-fix-send-close-message-upon-input-end
branch
from
3a37f39 to
eafd4d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't send one of these messages when the
streaminput ends, so the server can't know that the client is done!This change now correctly sends the end-of-stream message.