Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Adds Django 4.2 support and fixes trove classifiers #363

Merged
merged 12 commits into from
Oct 19, 2023

Conversation

jefftriplett
Copy link
Member

@jefftriplett jefftriplett commented Apr 7, 2023

This just checks a few boxes to get trove classifiers and CI testing...

I'm seeing a few warnings, but things are passing now (some of the RemovedInDjango51Warning might require dropping 2.2 support):

../../lib/python3.10/site-packages/kombu/utils/compat.py:82
tests/test_celery_ping.py::TestCeleryPingHealthCheck::test_check_status_doesnt_add_errors_when_ping_successful
  /Users/jefftriplett/.virtualenvs/django-health-check/lib/python3.10/site-packages/kombu/utils/compat.py:82: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
    for ep in importlib_metadata.entry_points().get(namespace, [])

../../lib/python3.10/site-packages/django/conf/__init__.py:193
  /Users/jefftriplett/.virtualenvs/django-health-check/lib/python3.10/site-packages/django/conf/__init__.py:193: RemovedInDjango51Warning: The DEFAULT_FILE_STORAGE setting is deprecated. Use STORAGES instead.
    self._show_deprecation_warning(

tests/test_storage.py::HealthCheckStorageTests::test_get_storage
  /Users/jefftriplett/.virtualenvs/django-health-check/lib/python3.10/site-packages/django/core/files/storage/__init__.py:32: RemovedInDjango51Warning: django.core.files.storage.get_storage_class is deprecated in favor of using django.core.files.storage.storages.
    warnings.warn(GET_STORAGE_CLASS_DEPRECATED_MSG, RemovedInDjango51Warning)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@jefftriplett jefftriplett marked this pull request as ready for review April 7, 2023 19:30
browniebroke and others added 2 commits October 19, 2023 10:09
* ⚙️ Adds Django 4.2 support and fixes trove classifiers

* :shirts: Runs black on code to make CI happy

* :shirts: Runs isort on code to make CI happy

* 💚 Updates test to match exception copy

* 📝 mirrors old README.rst to make docs work

Not a great solution, but a workaround.

* ⚙️ Adds pip cache support

* 🔥 Removes 4.0 from grid because it's no longer supported

* ⚙️ Updates cache-key

This isn't really used, but I think having caching is a win

* ⚙️ Adds missing file

* 🔥 Removes cache line

* Fix storages deprecation warnings

---------

Co-authored-by: Jeff Triplett <[email protected]>
@frankwiles frankwiles merged commit cc657b3 into master Oct 19, 2023
23 checks passed
@frankwiles frankwiles deleted the upgrade-django-to-4-2 branch October 19, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants