Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OU-407: Add monitoring-plugin uiplugin #575

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

PeterYurkovich
Copy link
Contributor

This PR looks to add an ACM specific version of the monitoring plugin into obo. It is reliant on changes in this PR which add the ACM specific flags.

This plugin should be deployable alongside the monitoring plugin deployed by CMO to allow for the local-cluster to still have the observability pages, while enabling the observability pages under ACM using the obo deployment.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 23, 2024

@PeterYurkovich: This pull request references OU-407 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

This PR looks to add an ACM specific version of the monitoring plugin into obo. It is reliant on changes in this PR which add the ACM specific flags.

This plugin should be deployable alongside the monitoring plugin deployed by CMO to allow for the local-cluster to still have the observability pages, while enabling the observability pages under ACM using the obo deployment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 23, 2024

Hi @PeterYurkovich. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PeterYurkovich
Copy link
Contributor Author

Updates to the monitoring-plugin PR have been completed which sync feature names and parameters with changes in this PR

@PeterYurkovich
Copy link
Contributor Author

/hold newest changes fail when ACM isn't installed

@PeterYurkovich
Copy link
Contributor Author

/unhold

Copy link

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgbernalp
Copy link
Contributor

/ok-to-test

@PeterYurkovich
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 48df915 into rhobs:main Oct 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants