-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OU-407: Add monitoring-plugin uiplugin #575
Conversation
@PeterYurkovich: This pull request references OU-407 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hi @PeterYurkovich. Thanks for your PR. I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Updates to the monitoring-plugin PR have been completed which sync feature names and parameters with changes in this PR |
/hold newest changes fail when ACM isn't installed |
/unhold |
fcfab32
to
4720364
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest |
This PR looks to add an ACM specific version of the monitoring plugin into obo. It is reliant on changes in this PR which add the ACM specific flags.
This plugin should be deployable alongside the monitoring plugin deployed by CMO to allow for the local-cluster to still have the observability pages, while enabling the observability pages under ACM using the obo deployment.