Nullability of reference types in value of type 'List<object>' doesn't match target type 'List<object?>'.

Nullability of reference types in value of type 'List<object>' doesn't match target type 'List<object?>'.

Process completed with exit code 1.

Nullability of reference types in value of type 'List<object>' doesn't match target type 'List<object?>'.

Nullability of reference types in value of type 'List<object>' doesn't match target type 'List<object?>'.

Process completed with exit code 1.

Test method DotVVM.Framework.Tests.ViewModel.GridViewDataSetTests.GridViewDataSet_DataPagerCommands_StaticCommand threw exception: Xunit.Sdk.EqualException: Assert.Equal() Failure ↓ (pos 51) Expected: ···ync (options)=>{let vm=options.viewModel;dotvvm.dataSet.trans··· Actual: ···ync (options)=>{let cx=options.knockoutContext;return await d··· ↑ (pos 51)

Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception: System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json index 042ab80..7f243aa 100644 --- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json +++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json @@ -348,6 +348,34 @@ "isCompileTimeOnly": true } }, + "DotVVM.Framework.Controls.AppendableDataPager": { + "DataSet": { + "type": "DotVVM.Framework.Controls.IPageableGridViewDataSet, DotVVM.Core", + "required": true, + "onlyBindings": true + }, + "EndTemplate": { + "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", + "mappingMode": "InnerElement", + "onlyHardcoded": true + }, + "LoadData": { + "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework", + "onlyBindings": true + }, + "LoadTemplate": { + "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", + "dataContextChange": [ + { + "$type": "DotVVM.Framework.Binding.HelperNamespace.DataPagerApi+AddParameterDataContextChangeAttribute, DotVVM.Framework", + "Name": "_dataPager", + "TypeId": "DotVVM.Framework.Binding.HelperNamespace.DataPagerApi+AddParameterDataContextChangeAttribute, DotVVM.Framework" + } + ], + "mappingMode": "InnerElement", + "onlyHardcoded": true + } + }, "DotVVM.Framework.Controls.AuthenticatedView": { "AuthenticatedTemplate": { "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", @@ -375,6 +403,10 @@ "type": "DotVVM.Framework.Binding.Expressions.Command, DotVVM.Framework", "isCommand": true }, + "ClickArguments": { + "type": "System.Collections.Generic.List`1[[System.Object, CoreLibrary]]", + "mappingMode": "Exclude" + }, "Enabled": { "type": "System.Boolean", "defaultValue": true @@ -731,6 +763,10 @@ "defaultValue": false, "onlyHardcoded": true }, + "LoadData": { + "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework", + "onlyBindings": true + }, "RowDecorators": { "type": "System.Collections.Generic.List`1[[DotVVM.Framework.Controls.Decorator, DotVVM.Framework, Version=***, Culture=neutral, PublicKeyToken=23f3607db32275da]]", "dataContextChange": [ @@ -1974,6 +2010,12 @@ "assembly": "DotVVM.Framework", "baseType": "DotVVM.Framework.Controls.DotvvmControl, DotVVM.Framework" }, + "DotVVM.Framework.Controls.AppendableDataPager": { + "assembly": "DotVVM.Framework", + "baseType": "DotVVM.Framework.Controls.HtmlGenericControl, DotVVM.Framework", + "defaultContentProperty": "LoadTemplate", + "withoutContent": true + }, "DotVVM.Framework.Controls.AuthenticatedView": { "assembly": "DotVVM.Framework", "baseType": "DotVVM.Framework.Controls.ConfigurableHtmlControl, DotVVM.Framework", Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicColumn threw exception: System.Exception: AutoUITests.BasicColumn.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html index 287823d..b418550 100644 --- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html +++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html @@ -3,7 +3,7 @@ <body> <!-- ko if: List()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }"> <thead> <tr> <th class=""> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicGrid threw exception: System.Exception: AutoUITests.BasicGrid.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html index ab33b4c..117a6f0 100644 --- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html +++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html @@ -3,7 +3,7 @@ <body> <!-- ko if: List()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }"> <thead> <tr> <th class=""> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.WrappedRepeaterControl threw exception: System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.CommandDataContextChange threw exception: DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.AutoclonedPostbackHandlers threw exception: DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.DataPagerTests.CommandDataPager threw exception: System.Exception: DataPagerTests.CommandDataPager.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html index 7f541e0..0b6f4a1 100644 --- a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html +++ b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html @@ -1,7 +1,7 @@ <html> <head></head> <body> - <ul data-bind="dotvvm-gridviewdataset: { dataSet: Customers() }, visible: (Customers()).PagingOptions().PagesCount() > 1"> + <ul data-bind="visible: Customers()?.PagingOptions()?.PagesCount() > 1"> <li class="disabled" data-bind="css: { disabled: Customers()?.PagingOptions()?.IsFirstPage }"> <a href="javascript:;" onclick="dotvvm.postBack(this,[],&quot;XV5Ciz2t6C9bIsEQ&quot;,&quot;&quot;,null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">««</a> </li> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.GridViewTests.RequiredResourceInEditTemplate threw exception: System.Exception: GridViewTests.RequiredResourceInEditTemplate.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html index 0e56043..d164cdd 100644 --- a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html +++ b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html @@ -3,7 +3,7 @@ <body> <!-- ko if: EmptyCustomers()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':EmptyCustomers()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: EmptyCustomers(), mapping: {} }"> <thead> <tr> <th> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.ServerSideStyleTests.BindableObjectReads threw exception: System.Exception: ServerSideStyleTests.BindableObjectReads.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html index 383b9dd..e1b1422 100644 --- a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html +++ b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html @@ -4,7 +4,7 @@ <!-- no header attribute --> <!-- ko if: Collection()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }"> <thead> <tr> <th> @@ -23,7 +23,7 @@ <!-- /ko --> <!-- has header attribute --> <!-- ko if: Collection()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}" data-headers="RealValue ; Test"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }" data-headers="RealValue ; Test"> <thead> <tr> <th> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ViewModel.GridViewDataSetTests.GridViewDataSet_DataPagerCommands_StaticCommand threw exception: Xunit.Sdk.EqualException: Assert.Equal() Failure ↓ (pos 51) Expected: ···ync (options)=>{let vm=options.viewModel;dotvvm.dataSet.trans··· Actual: ···ync (options)=>{let cx=options.knockoutContext;return await d··· ↑ (pos 51)

Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception: System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json index 042ab80..7f243aa 100644 --- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json +++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json @@ -348,6 +348,34 @@ "isCompileTimeOnly": true } }, + "DotVVM.Framework.Controls.AppendableDataPager": { + "DataSet": { + "type": "DotVVM.Framework.Controls.IPageableGridViewDataSet, DotVVM.Core", + "required": true, + "onlyBindings": true + }, + "EndTemplate": { + "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", + "mappingMode": "InnerElement", + "onlyHardcoded": true + }, + "LoadData": { + "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework", + "onlyBindings": true + }, + "LoadTemplate": { + "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", + "dataContextChange": [ + { + "$type": "DotVVM.Framework.Binding.HelperNamespace.DataPagerApi+AddParameterDataContextChangeAttribute, DotVVM.Framework", + "Name": "_dataPager", + "TypeId": "DotVVM.Framework.Binding.HelperNamespace.DataPagerApi+AddParameterDataContextChangeAttribute, DotVVM.Framework" + } + ], + "mappingMode": "InnerElement", + "onlyHardcoded": true + } + }, "DotVVM.Framework.Controls.AuthenticatedView": { "AuthenticatedTemplate": { "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", @@ -375,6 +403,10 @@ "type": "DotVVM.Framework.Binding.Expressions.Command, DotVVM.Framework", "isCommand": true }, + "ClickArguments": { + "type": "System.Collections.Generic.List`1[[System.Object, CoreLibrary]]", + "mappingMode": "Exclude" + }, "Enabled": { "type": "System.Boolean", "defaultValue": true @@ -731,6 +763,10 @@ "defaultValue": false, "onlyHardcoded": true }, + "LoadData": { + "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework", + "onlyBindings": true + }, "RowDecorators": { "type": "System.Collections.Generic.List`1[[DotVVM.Framework.Controls.Decorator, DotVVM.Framework, Version=***, Culture=neutral, PublicKeyToken=23f3607db32275da]]", "dataContextChange": [ @@ -1974,6 +2010,12 @@ "assembly": "DotVVM.Framework", "baseType": "DotVVM.Framework.Controls.DotvvmControl, DotVVM.Framework" }, + "DotVVM.Framework.Controls.AppendableDataPager": { + "assembly": "DotVVM.Framework", + "baseType": "DotVVM.Framework.Controls.HtmlGenericControl, DotVVM.Framework", + "defaultContentProperty": "LoadTemplate", + "withoutContent": true + }, "DotVVM.Framework.Controls.AuthenticatedView": { "assembly": "DotVVM.Framework", "baseType": "DotVVM.Framework.Controls.ConfigurableHtmlControl, DotVVM.Framework", Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicColumn threw exception: System.Exception: AutoUITests.BasicColumn.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html index 287823d..b418550 100644 --- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html +++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html @@ -3,7 +3,7 @@ <body> <!-- ko if: List()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }"> <thead> <tr> <th class=""> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicGrid threw exception: System.Exception: AutoUITests.BasicGrid.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html index ab33b4c..117a6f0 100644 --- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html +++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html @@ -3,7 +3,7 @@ <body> <!-- ko if: List()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }"> <thead> <tr> <th class=""> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.WrappedRepeaterControl threw exception: System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.CommandDataContextChange threw exception: DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.AutoclonedPostbackHandlers threw exception: DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.DataPagerTests.CommandDataPager threw exception: System.Exception: DataPagerTests.CommandDataPager.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html index 7f541e0..0b6f4a1 100644 --- a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html +++ b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html @@ -1,7 +1,7 @@ <html> <head></head> <body> - <ul data-bind="dotvvm-gridviewdataset: { dataSet: Customers() }, visible: (Customers()).PagingOptions().PagesCount() > 1"> + <ul data-bind="visible: Customers()?.PagingOptions()?.PagesCount() > 1"> <li class="disabled" data-bind="css: { disabled: Customers()?.PagingOptions()?.IsFirstPage }"> <a href="javascript:;" onclick="dotvvm.postBack(this,[],&quot;XV5Ciz2t6C9bIsEQ&quot;,&quot;&quot;,null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">««</a> </li> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.GridViewTests.RequiredResourceInEditTemplate threw exception: System.Exception: GridViewTests.RequiredResourceInEditTemplate.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html index 0e56043..d164cdd 100644 --- a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html +++ b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html @@ -3,7 +3,7 @@ <body> <!-- ko if: EmptyCustomers()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':EmptyCustomers()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: EmptyCustomers(), mapping: {} }"> <thead> <tr> <th> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.ServerSideStyleTests.BindableObjectReads threw exception: System.Exception: ServerSideStyleTests.BindableObjectReads.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html index 383b9dd..e1b1422 100644 --- a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html +++ b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html @@ -4,7 +4,7 @@ <!-- no header attribute --> <!-- ko if: Collection()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }"> <thead> <tr> <th> @@ -23,7 +23,7 @@ <!-- /ko --> <!-- has header attribute --> <!-- ko if: Collection()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}" data-headers="RealValue ; Test"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }" data-headers="RealValue ; Test"> <thead> <tr> <th> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ViewModel.GridViewDataSetTests.GridViewDataSet_DataPagerCommands_StaticCommand threw exception: Xunit.Sdk.EqualException: Assert.Equal() Failure ↓ (pos 51) Expected: ···ync (options)=>{let vm=options.viewModel;dotvvm.dataSet.trans··· Actual: ···ync (options)=>{let cx=options.knockoutContext;return await d··· ↑ (pos 51)

Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception: System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json index 042ab80..7f243aa 100644 --- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json +++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json @@ -348,6 +348,34 @@ "isCompileTimeOnly": true } }, + "DotVVM.Framework.Controls.AppendableDataPager": { + "DataSet": { + "type": "DotVVM.Framework.Controls.IPageableGridViewDataSet, DotVVM.Core", + "required": true, + "onlyBindings": true + }, + "EndTemplate": { + "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", + "mappingMode": "InnerElement", + "onlyHardcoded": true + }, + "LoadData": { + "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework", + "onlyBindings": true + }, + "LoadTemplate": { + "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", + "dataContextChange": [ + { + "$type": "DotVVM.Framework.Binding.HelperNamespace.DataPagerApi+AddParameterDataContextChangeAttribute, DotVVM.Framework", + "Name": "_dataPager", + "TypeId": "DotVVM.Framework.Binding.HelperNamespace.DataPagerApi+AddParameterDataContextChangeAttribute, DotVVM.Framework" + } + ], + "mappingMode": "InnerElement", + "onlyHardcoded": true + } + }, "DotVVM.Framework.Controls.AuthenticatedView": { "AuthenticatedTemplate": { "type": "DotVVM.Framework.Controls.ITemplate, DotVVM.Framework", @@ -375,6 +403,10 @@ "type": "DotVVM.Framework.Binding.Expressions.Command, DotVVM.Framework", "isCommand": true }, + "ClickArguments": { + "type": "System.Collections.Generic.List`1[[System.Object, CoreLibrary]]", + "mappingMode": "Exclude" + }, "Enabled": { "type": "System.Boolean", "defaultValue": true @@ -731,6 +763,10 @@ "defaultValue": false, "onlyHardcoded": true }, + "LoadData": { + "type": "DotVVM.Framework.Binding.Expressions.ICommandBinding, DotVVM.Framework", + "onlyBindings": true + }, "RowDecorators": { "type": "System.Collections.Generic.List`1[[DotVVM.Framework.Controls.Decorator, DotVVM.Framework, Version=***, Culture=neutral, PublicKeyToken=23f3607db32275da]]", "dataContextChange": [ @@ -1974,6 +2010,12 @@ "assembly": "DotVVM.Framework", "baseType": "DotVVM.Framework.Controls.DotvvmControl, DotVVM.Framework" }, + "DotVVM.Framework.Controls.AppendableDataPager": { + "assembly": "DotVVM.Framework", + "baseType": "DotVVM.Framework.Controls.HtmlGenericControl, DotVVM.Framework", + "defaultContentProperty": "LoadTemplate", + "withoutContent": true + }, "DotVVM.Framework.Controls.AuthenticatedView": { "assembly": "DotVVM.Framework", "baseType": "DotVVM.Framework.Controls.ConfigurableHtmlControl, DotVVM.Framework", Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicColumn threw exception: System.Exception: AutoUITests.BasicColumn.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html index 287823d..b418550 100644 --- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html +++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicColumn.html @@ -3,7 +3,7 @@ <body> <!-- ko if: List()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }"> <thead> <tr> <th class=""> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.BasicGrid threw exception: System.Exception: AutoUITests.BasicGrid.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html index ab33b4c..117a6f0 100644 --- a/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html +++ b/src/Tests/ControlTests/testoutputs/AutoUITests.BasicGrid.html @@ -3,7 +3,7 @@ <body> <!-- ko if: List()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':List()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: List(), mapping: {} }"> <thead> <tr> <th class=""> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.WrappedRepeaterControl threw exception: System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.CommandDataContextChange threw exception: DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.CompositeControlTests.AutoclonedPostbackHandlers threw exception: DotVVM.Framework.Compilation.DotvvmCompilationException: Failed to precompile control 'RepeatedButton2': Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property. ---> System.NotSupportedException: Value 'System.Collections.Generic.List`1[System.Object]' of type System.Collections.Generic.List`1[System.Object] in ButtonBase.ClickArguments cannot be compiled into a property.

Test method DotVVM.Framework.Tests.ControlTests.DataPagerTests.CommandDataPager threw exception: System.Exception: DataPagerTests.CommandDataPager.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html index 7f541e0..0b6f4a1 100644 --- a/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html +++ b/src/Tests/ControlTests/testoutputs/DataPagerTests.CommandDataPager.html @@ -1,7 +1,7 @@ <html> <head></head> <body> - <ul data-bind="dotvvm-gridviewdataset: { dataSet: Customers() }, visible: (Customers()).PagingOptions().PagesCount() > 1"> + <ul data-bind="visible: Customers()?.PagingOptions()?.PagesCount() > 1"> <li class="disabled" data-bind="css: { disabled: Customers()?.PagingOptions()?.IsFirstPage }"> <a href="javascript:;" onclick="dotvvm.postBack(this,[],&quot;XV5Ciz2t6C9bIsEQ&quot;,&quot;&quot;,null,[],[],undefined).catch(dotvvm.log.logPostBackScriptError);event.stopPropagation();return false;">««</a> </li> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.GridViewTests.RequiredResourceInEditTemplate threw exception: System.Exception: GridViewTests.RequiredResourceInEditTemplate.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html index 0e56043..d164cdd 100644 --- a/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html +++ b/src/Tests/ControlTests/testoutputs/GridViewTests.RequiredResourceInEditTemplate.html @@ -3,7 +3,7 @@ <body> <!-- ko if: EmptyCustomers()?.Items()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':EmptyCustomers()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: EmptyCustomers(), mapping: {} }"> <thead> <tr> <th> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Test method DotVVM.Framework.Tests.ControlTests.ServerSideStyleTests.BindableObjectReads threw exception: System.Exception: ServerSideStyleTests.BindableObjectReads.html has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html index 383b9dd..e1b1422 100644 --- a/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html +++ b/src/Tests/ControlTests/testoutputs/ServerSideStyleTests.BindableObjectReads.html @@ -4,7 +4,7 @@ <!-- no header attribute --> <!-- ko if: Collection()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }"> <thead> <tr> <th> @@ -23,7 +23,7 @@ <!-- /ko --> <!-- has header attribute --> <!-- ko if: Collection()?.length --> - <table data-bind="dotvvm-gridviewdataset: {'mapping':{},'dataSet':Collection()}" data-headers="RealValue ; Test"> + <table data-bind="dotvvm-gridviewdataset: { dataSet: Collection(), mapping: {} }" data-headers="RealValue ; Test"> <thead> <tr> <th> Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file

Action failed since 3 tests failed.

Process completed with exit code 1.

Action failed since 5 tests failed.

Process completed with exit code 1.

Action failed since 3 tests failed.

Process completed with exit code 1.

Action failed since 3 tests failed.

Process completed with exit code 1.

Action failed since 3 tests failed.

Process completed with exit code 1.

Action failed since 3 tests failed.

Process completed with exit code 1.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

Detected Razor language version downgrade. This is typically caused by a reference to the Microsoft.AspNetCore.Razor.Design package. Consider removing this package reference.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)

Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)