Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pC commands to rzshell #3213

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Convert pC commands to rzshell #3213

merged 1 commit into from
Jan 23, 2023

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Nov 28, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Converted pC commands to rzshell
  • Removed pCc command because there is no use for printing C-style array in columns

Test plan

CI is green

Closing issues

Partially addresses #1590

@XVilka XVilka mentioned this pull request Nov 28, 2022
32 tasks
Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any super simple test we can add for these commands? You can use scr.columns/scr.rows to force the size of the RzCons so it is reproducible.

@XVilka
Copy link
Member Author

XVilka commented Jan 23, 2023

@ret2libc everything should be fixed now - the problem with pCA was that it was using pxA which changed behavior since - it limits itself to the block size in the short form (pxA) but works fine in the long form (pxAl).

@ret2libc
Copy link
Member

image

The problem is that the second columns starts at 0x100003a64, but the first one ends with 0x100003a5c. So there is an instruction (0x100003a60) that is not displayed.

However... this is not strictly a problem with your conversion, so if you want go ahead but let's create an issue for this at least.

@XVilka
Copy link
Member Author

XVilka commented Jan 23, 2023

OK: #3318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants