Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPC/ARM] Update to Capstone v6/auto-sync #3648

Merged
merged 106 commits into from
Oct 18, 2023
Merged

[PPC/ARM] Update to Capstone v6/auto-sync #3648

merged 106 commits into from
Oct 18, 2023

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Jul 8, 2023 •
edited by XVilka
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Based on #3591

Detailed description

  • Updates the ARM module to Capstone's v6/auto-sync version.
  • Updates the PPC module to Capstone's v6/auto-sync version.

Based on ARM cs v6 update (#3591).

Todo after merge: Add already implemented instructions CR and ISEL: #2901

Test plan

CI is green

Closing issues

closes #1306

@Rot127 Rot127 changed the base branch from capstone-ng to dev July 20, 2023 12:02
@github-actions github-actions bot removed documentation Improvements or additions to documentation infrastructure rz-bin RzIO RzBin API labels Jul 20, 2023
Rot127 added 25 commits October 11, 2023 16:35
@Rot127
Fix rzil tests (with simplified semantics)
efc3d11
@Rot127
Fix branch alias with new cond test method.
6e4c343
@Rot127
Handle clrl. alias
32b654d
@Rot127
Handle SL/SR alias
0af402d
@Rot127
Fix conditional braches in ESIL.
424afb4
@Rot127
Fix possible multiplication result overflow.
d9fba14
@Rot127
Set capstone-next to newest commit .
bc3b743
@Rot127
Add RZ_NONNULL
2b19e02
@Rot127
Use Capstone's next branch as default branch
84c5ceb
@Rot127
Run clang-format
d75e11b
@Rot127
Add 0 register
c12f3c5
@Rot127
Handle LIS alias
5d4dc79
@Rot127
Fix: Print crX reg name in CS v6
afa18ac
@Rot127
Handle all general branch instructions into a single case statement.
d5625b0
@Rot127
Fix no semantic issues in tests.
1061887
@Rot127
Add new discovered calls
16f1aa0
@Rot127
Move direction check to inline functoin.
e843fcb
@Rot127
Add link of root cause for broken test.
f55a264
@Rot127
Add QPX support.
c60f9f6
@Rot127
Set Capstone next branch to latest commit.
a47fea1
@Rot127
Run clang-format
a9c62ab
@Rot127
Fix uninitialized warning.
dc905df
@Rot127
Set CS next branch to newes commit
466f2af
@Rot127
Remove CS auto-sync subproject branches.
697de35
@Rot127
Set correct commit hash
8bfc691
XVilka
XVilka approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is.

@XVilka
Copy link
Member

XVilka commented Oct 16, 2023

@wargio @ret2libc @thestr4ng3r please take a look and lets merge this before 0.7.0

wargio
wargio approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks completely capstone earlier versions. i strongly would push to just deprecate it.

@wargio wargio merged commit 1018286 into rizinorg:dev Oct 18, 2023
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka XVilka approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
ARM capstone high-priority PPC rz-test RzAnalysis
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

PowerPC QPX not supported
3 participants
@Rot127 @XVilka @wargio