Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "rz-test: Set default test dir to '.' (#4741)" #4759

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Dec 7, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr reverts #4741 since apparently it has code that allows tests in the official Rizin test hierarchy to find their test binaries (in test/bins) no matter what the current working directory is.

Test plan

Given the test/db/cmd/cmd_pd testfile pathname, all of the following should work:

  1. rz-test test/db/cmd/cmd_pd in the root folder
  2. rz-test db/cmd/cmd_pd in the test/ folder
  3. rz-test cmd/cmd_pd in the test/db folder
  4. rz-test cmd_pd in the test/db/cmd folder

One cannot prepend ./ to the rz-test arguments above though (except for number 2 for some reason -- rz-test ./db/cmd/cmd_pd in the test/ folder works), but that's an issue for another pr.

Also, all builds should be green.

Closing issues

...

@kazarmy
Copy link
Member Author

kazarmy commented Dec 7, 2024

Updated the pr header comment

binrz/rz-test/rz-test.c Show resolved Hide resolved
binrz/rz-test/rz-test.c Show resolved Hide resolved
@kazarmy kazarmy marked this pull request as draft December 7, 2024 14:07
@kazarmy kazarmy marked this pull request as ready for review December 8, 2024 04:49
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing the documentation!

@kazarmy kazarmy merged commit 82d5596 into rizinorg:dev Dec 9, 2024
45 checks passed
@kazarmy kazarmy mentioned this pull request Dec 14, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants