Revert "rz-test: Set default test dir to '.' (#4741)" #4759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This pr reverts #4741 since apparently it has code that allows tests in the official Rizin test hierarchy to find their test binaries (in
test/bins
) no matter what the current working directory is.Test plan
Given the
test/db/cmd/cmd_pd
testfile pathname, all of the following should work:rz-test test/db/cmd/cmd_pd
in the root folderrz-test db/cmd/cmd_pd
in thetest/
folderrz-test cmd/cmd_pd
in thetest/db
folderrz-test cmd_pd
in thetest/db/cmd
folderOne cannot prepend
./
to therz-test
arguments above though (except for number 2 for some reason --rz-test ./db/cmd/cmd_pd
in thetest/
folder works), but that's an issue for another pr.Also, all builds should be green.
Closing issues
...