Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add new Kuavo Humanoid robot model to env, and make Kuavo replay retargeted mocap data. #12

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

wangshub
Copy link

@wangshub wangshub commented Feb 21, 2024

Hi @robfiras

According to your reply, I have successfully imported the Kuavo robot, which is a video screenshot of playing back mocap data.

#8 (comment)

2024-02-21.132124.mp4

@robfiras
Copy link
Owner

Many thanks for your contribution!
I will start reviewing the PR soon.

@robfiras
Copy link
Owner

robfiras commented Feb 27, 2024

Hi @wangshub,
I checkedout your PR. Here are the preliminary TODOs for us:

Work on the XML (by @wangshub )

  • can we get all the meshes? Right now, many are missing.
  • can we get maximum torque values for the motors? Right now all are set to 100, which is not realistic.
  • what is the license of the model? Are you working in that company?

Work on the API (by @robfiras )

  • decide on what tasks are suitable for the kuavo
  • clean up the main class
  • adapt data generation

@robfiras robfiras self-assigned this Feb 27, 2024
@robfiras robfiras added the enhancement New feature or request label Feb 27, 2024
@wangshub
Copy link
Author

@robfiras Yes, I work at Leju Robotics. We will complete the TODOs as soon as possible !

@1190201119
Copy link

@robfiras Yes, I work at Leju Robotics. We will complete the TODOs as soon as possible !

事实上执行器的力矩根本就没有设置,设置到减速比上去了。考虑到我们实际上使用的是一体化关节,或者说我们并不关心电机传动前的输出,gear根本就不用设置。

@wangshub
Copy link
Author

wangshub commented Mar 5, 2024

Hi ! @robfiras

  • All torque values for the motors are fixed by realistic parameters.
  • License declaration is included in kuavo.xml
  • the necessary meshes are included in the model, we have removed the lower body shell meshes of the robot for now to improve flexibility. I will submit a new PR if there are any further updates.

@robfiras
Copy link
Owner

Hi @wangshub,

thanks for the changes! And sorry for the delay ...

I would ask you to add the shell meshes of the lower body and the arms as well. Right now, it does not look nice. We do not want to add preliminary models to this repo.

In the meantime, I will update the datasets and see if we can train a gait using your models.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants