Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include SecurityCapabilities test in rbx_dom_lua #362

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Don't include SecurityCapabilities test in rbx_dom_lua #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc8db8d
Add unimplemented pod to EncodedValues
Dekkonot Sep 21, 2023
a047b97
Don't test SecurityCapabilities roundtrip
Dekkonot Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions rbx_dom_lua/src/EncodedValue.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,15 @@ types = {
end,
},

SecurityCapabilities = {
fromPod = function(pod)
error("SecurityCapabilities is not implemented")
end,
toPod = function(roblox)
error("SecurityCapabilities is not implemented")
end
},

SharedString = {
fromPod = function(pod)
error("SharedString is not supported")
Expand Down
8 changes: 2 additions & 6 deletions rbx_reflector/src/cli/values.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ use rbx_types::{
Attributes, Axes, BinaryString, BrickColor, CFrame, Color3, Color3uint8, ColorSequence,
ColorSequenceKeypoint, Content, CustomPhysicalProperties, Enum, Faces, Font, MaterialColors,
Matrix3, NumberRange, NumberSequence, NumberSequenceKeypoint, PhysicalProperties, Ray, Rect,
Region3int16, SecurityCapabilities, Tags, TerrainMaterials, UDim, UDim2, Variant, VariantType,
Vector2, Vector2int16, Vector3, Vector3int16,
Region3int16, Tags, TerrainMaterials, UDim, UDim2, Variant, VariantType, Vector2, Vector2int16,
Vector3, Vector3int16,
};
use serde::Serialize;

Expand Down Expand Up @@ -176,10 +176,6 @@ impl ValuesSubcommand {
values.insert("Vector2int16", Vector2int16::new(-300, 300).into());
values.insert("Vector3", Vector3::new(-300.0, 0.0, 1500.0).into());
values.insert("Vector3int16", Vector3int16::new(60, 37, -450).into());
values.insert(
"SecurityCapabilities",
SecurityCapabilities::from_bits(256).into(),
);

let entries: BTreeMap<&str, TestEntry> = values
.into_iter()
Expand Down