Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused state_ field #215

Conversation

firesurfer
Copy link
Contributor

The state_ field is not used.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (1ce4df7) to head (e481fef).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files           7        7           
  Lines         429      429           
  Branches       71       71           
=======================================
  Hits          312      312           
  Misses         73       73           
  Partials       44       44           
Flag Coverage Δ
unittests 72.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ude/realtime_tools/realtime_server_goal_handle.hpp 73.68% <ø> (ø)

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich merged commit cb3a297 into ros-controls:master Dec 2, 2024
25 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport humble

Copy link

mergify bot commented Dec 4, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 4, 2024
(cherry picked from commit cb3a297)

# Conflicts:
#	include/realtime_tools/realtime_server_goal_handle.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants