changed install directory so other pkgs can ament_target_depend on th… #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The checks failed because the CI workflow file was pointing to the wrong yaml file. I pushed the necessary changes to the master but now your branch is behind by that commit. Could you please pull master and rebase to it, then push to your PR branch again so I can rerun the tests? Thanks! |
|
@buckleytoby can you merge master and push to your PR branch again? It should trigger a rebuild so we know the tests pass. Thanks! |
| @@ -91,6 +91,7 @@ void FFMPEGEncoder::setParameters(rclcpp::Node * node) | |||
| profile_ = get_safe_param<std::string>(node, ns + "profile", ""); | |||
| preset_ = get_safe_param<std::string>(node, ns + "preset", ""); | |||
| tune_ = get_safe_param<std::string>(node, ns + "tune", ""); | |||
| delay_ = get_safe_param<std::string>(node, ns + "delay", ""); | |||
There was a problem hiding this comment.
Please update README.md to reflect this new parameter.
berndpfrommer
approved these changes
Jan 3, 2024
|
Since I got no response from @buckleytoby I merged the change without any documentation :( |
|
hey, sorry, I've been sick all week so haven't had the chance to revisit this. Will return to it on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is library