Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated security methods #77

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Deprecated security methods #77

merged 5 commits into from
Feb 14, 2025
+75 −98

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 24, 2025

These functions are not DDS specific, now that we have zenoh as an rmw we should move these functions to a more generic place.

I move to rmw_security_common, in sros2.

Related PR ros2/sros2#330

@ahcorde
Deprecated security methods
9c9d63e 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Jan 24, 2025
@ahcorde
make linters happy
eeb86aa 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
fujitatomoya
fujitatomoya reviewed Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we decide where to move this functions, i think that is okay to deprecate those functions. those functions are not specific for DDS, but more like standard for pkcs#11.

@ahcorde
Use API from rmw_security_common
e56dbe3 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde mentioned this pull request Jan 29, 2025
Open
@ahcorde
export dependency
7359439 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Feedback
c642014 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde requested a review from fujitatomoya February 11, 2025 13:15
fujitatomoya
fujitatomoya approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

This was referenced Feb 12, 2025
Merged
Merged
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: ros2/rmw#388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, #77
Gist: https://gist.githubusercontent.com/ahcorde/c0bfb74dcaed3942f416c34a9b490f47/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15176

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Feb 12, 2025
Merged
Merged
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: ros2/rmw#388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, #77
Gist: https://gist.githubusercontent.com/ahcorde/5b78efa6d3ca4e7fdb4dd2e3fca2fe72/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15177

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: ros2/rmw#388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, #77
Gist: https://gist.githubusercontent.com/ahcorde/21ab5b7ad3122eb4c98d300a252b2754/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common --packages-above-and-dependencies rmw_security_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common --packages-above rmw_security_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15178

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: ros2/rmw#388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, #77
Gist: https://gist.githubusercontent.com/ahcorde/2568a2beac974257b33e414c23d331ed/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15183

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: ros2/rmw#388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, #77
Gist: https://gist.githubusercontent.com/ahcorde/e86ea6f6c25a1fe0b28a6d6af0a35daf/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15184

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 13, 2025

Pulls: ros2/rmw#388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, #77
Gist: https://gist.githubusercontent.com/ahcorde/f529df4f2761b821f1de877299fbd650/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15185

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 14, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 66b5295 into rolling Feb 14, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/deprecated_secutiry_methods branch February 14, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @fujitatomoya