Rosidl python incompatability #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Aug 10, 2022
There was a problem hiding this comment.
I think the warning is a good addition to the guide, however there are several other orthogonal changes being introduced in this pull request. It is preferred if each pull request is focused on one thing. I kindly ask that you revert the other unrelated commits and optionally propose them in separate pull requests. Thanks!
source/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.rst
Outdated
Show resolved
Hide resolved
RFRIEDM-Trimble
force-pushed
the
rosidl_python_incompatability
branch
from
eac90b2
to
c5500e7
Compare
Closed
RFRIEDM-Trimble
force-pushed
the
rosidl_python_incompatability
branch
from
c5500e7
to
4915267
Compare
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
RFRIEDM-Trimble
force-pushed
the
rosidl_python_incompatability
branch
from
4915267
to
d806ebe
Compare
2 tasks
jacobperron
added
the
backport-all
jacobperron
approved these changes
Aug 18, 2022
|
@RFRIEDM-Trimble Thanks for iterating! |
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
… the same project (#2882) * Add warning as recommended in ros2/rosidl_python#141 Signed-off-by: Ryan Friedman <[email protected]> * Move warning to after ament_python_install_package instructions Signed-off-by: Ryan Friedman <[email protected]> (cherry picked from commit 030bc61)
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
… the same project (#2882) * Add warning as recommended in ros2/rosidl_python#141 Signed-off-by: Ryan Friedman <[email protected]> * Move warning to after ament_python_install_package instructions Signed-off-by: Ryan Friedman <[email protected]> (cherry picked from commit 030bc61)
This was referenced Aug 18, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
… the same project (#2882) * Add warning as recommended in ros2/rosidl_python#141 Signed-off-by: Ryan Friedman <[email protected]> * Move warning to after ament_python_install_package instructions Signed-off-by: Ryan Friedman <[email protected]> (cherry picked from commit 030bc61)
clalancette
pushed a commit
that referenced
this pull request
Aug 19, 2022
… the same project (#2882) (#2971) * Add warning as recommended in ros2/rosidl_python#141 Signed-off-by: Ryan Friedman <[email protected]> * Move warning to after ament_python_install_package instructions Signed-off-by: Ryan Friedman <[email protected]> (cherry picked from commit 030bc61) Co-authored-by: RFRIEDM-Trimble <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Aug 19, 2022
… the same project (#2882) (#2970) * Add warning as recommended in ros2/rosidl_python#141 Signed-off-by: Ryan Friedman <[email protected]> * Move warning to after ament_python_install_package instructions Signed-off-by: Ryan Friedman <[email protected]> (cherry picked from commit 030bc61) Co-authored-by: RFRIEDM-Trimble <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Aug 19, 2022
… the same project (#2882) (#2969) * Add warning as recommended in ros2/rosidl_python#141 Signed-off-by: Ryan Friedman <[email protected]> * Move warning to after ament_python_install_package instructions Signed-off-by: Ryan Friedman <[email protected]> (cherry picked from commit 030bc61) Co-authored-by: RFRIEDM-Trimble <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a warning to prevent users from running into ros2/rosidl_python#141.
This is my first contribution to the docs. I followed the guides, had some issues in the developer guide, and cleaned those up in a separate commit.
If possible, please backport this into
humbleas that is where this issue showed up. It does not happen ingalactic, at least right now, however it may be a good idea to warn users anyways such that when they move tohumble, they aren't surprised.Here's the new rendered changes:
