feat: added drop traits in track call feature for mixpanel #1870
Conversation
manish339k
requested review from
lvrach,
cisse21,
debanjan97,
am6010,
ssbeefeater,
ItsSudip,
sandeepdsvs,
krishna2020 and
1abhishekpandey
as code owners
WalkthroughThe changes introduce a new configuration option Changes
Sequence DiagramsequenceDiagram
participant User as User
participant UI as Configuration UI
participant Config as Configuration
participant Tracking as Tracking Service
User->>UI: Set "Drop Traits" option
UI->>Config: Update dropTraitsInTrackEvent
Config-->>Tracking: Apply trait dropping setting
Tracking->>Tracking: Process track event
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1870 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/configurations/destinations/mp/ui-config.json (1)
165-186: Consider enhancing the feature description.While the UI configuration is well-structured, the note could be more descriptive about the impact of enabling this feature. Consider expanding it to explain:
- What traits are being dropped
- The impact on tracking data
- When users might want to enable this option
- "note": "Drop traits from event property in track call", + "note": "When enabled, user traits will be excluded from event properties in track calls. Enable this to reduce event property payload size and prevent duplicate user information in your tracking data.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/configurations/destinations/mp/db-config.json(1 hunks)src/configurations/destinations/mp/schema.json(1 hunks)src/configurations/destinations/mp/ui-config.json(1 hunks)test/data/validation/destinations/mp.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (2)
src/configurations/destinations/mp/db-config.json (1)
112-113: LGTM!The new configuration key is properly added to the defaultConfig array, maintaining consistency with the existing structure.
src/configurations/destinations/mp/schema.json (1)
42-45: LGTM!The schema definition is correct with appropriate type and default value, ensuring backward compatibility.
What are the changes introduced in this PR?
Added new toggle button to drop traits from event property in track call.
What is the related Linear task?
Resolves INT-3100
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit
Release Notes
New Features
Configuration Updates
Validation
dropTraitsInTrackEventis a boolean value