Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KLabel variables #3877

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Remove KLabel variables #3877

merged 5 commits into from
Dec 15, 2023

Conversation

Scott-Guest
Copy link
Contributor

@Scott-Guest Scott-Guest commented Dec 13, 2023 •
edited
Loading

This PR removes all logic related to KLabel variables because

  • They are unsupported by any modern backend
  • Without KLabel variables, we can assume every variable has sort S with KBott < S <= K, which addresses some minor annoyances in the sort inferencer.

@Scott-Guest Scott-Guest self-assigned this Dec 13, 2023
@Scott-Guest Scott-Guest marked this pull request as ready for review December 14, 2023 18:11
@Scott-Guest Scott-Guest mentioned this pull request Dec 15, 2023
Merged
@rv-jenkins rv-jenkins merged commit 8ac8754 into develop Dec 15, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the klabel-var-check branch December 15, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radumereuta radumereuta radumereuta approved these changes

@Baltoli Baltoli Awaiting requested review from Baltoli

@dwightguth dwightguth Awaiting requested review from dwightguth

@ehildenb ehildenb Awaiting requested review from ehildenb ehildenb is a code owner

Assignees

@Scott-Guest Scott-Guest

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scott-Guest @radumereuta @rv-jenkins