Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on macOS using clang and fix compilation using zig-cc #1364

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

NobodyXu
Copy link
Collaborator

Fixed #1362 #1360

@madsmtm madsmtm added bug O-apple Apple targets and toolchains labels Jan 12, 2025
Copy link
Collaborator

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, Homebrew continues to be the bane of my existence... Looks good though.

src/tool.rs Show resolved Hide resolved
@NobodyXu NobodyXu enabled auto-merge (squash) January 12, 2025 05:13
Copy link

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the patch works for me. Thanks!

@NobodyXu NobodyXu merged commit 9b91744 into main Jan 12, 2025
103 checks passed
@NobodyXu NobodyXu deleted the fix/clang-and-zig-cc branch January 12, 2025 05:16
@chenrui333
Copy link

do you guys also plan a new release soonish? (need to refresh some of my PR updates)

@NobodyXu
Copy link
Collaborator Author

Yes within today

@chenrui333
Copy link

Thanks @NobodyXu! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug O-apple Apple targets and toolchains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with 1.2.8 release
3 participants