-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from setup.py to pyproject.toml #51
Conversation
- Remove reference to aas-compliance-check from pyproject.toml - Add newline at end of pyproject.toml - Remove entry point for aas-compliance-check from setup.py
This pull request updates the build configuration by modifying the pyproject.toml and setup.py files to include development dependencies and refine the project setup. The goal is to improve the development environment setup and ensure consistent dependency management. Changes:
Procedure: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the Python ecosystem moves toward pyproject.toml
, it's often recommended to fully migrate from setup.py
to pyproject.toml.
As long as there is not concrete reason not to migrate fully, I would suggest to delete the setup.py
.
Can you please point this PR to |
Can you also please update your branch, now that eclipse-basyx/basyx-python-sdk#238 has been merged? |
Do we still need this PR or can it be closed with respect to the new eclipse-basyx/basyx-python-sdk#290? |
I think this PR can be closed. |
This pull request updates the build configuration by modifying the pyproject.toml and setup.py files to include development dependencies and refine the project setup. The goal is to improve the development environment setup and ensure consistent dependency management.
Changes:
Added dev optional dependencies section to include pytest, flake8, coverage, and other development tools. Refined project metadata such as version, authors, and dependencies. Improved package data and exclusion configuration.
Ensured compatibility with the changes in pyproject.toml.
Procedure:
CI Configuration:
The ci.yml file has been updated to use the dev dependencies during the CI pipeline runs. This ensures that all necessary development tools are installed for testing and code quality checks.
Development Setup:
To set up the development environment locally, run:
pip install .[dev]
This will install the package along with all development dependencies specified in the pyproject.toml and setup.py files.
Impact:
These changes streamline the setup process for new developers and CI environments.
Ensures that the development and testing environments are consistent across different setups.