Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes for demo #39

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Misc fixes for demo #39

merged 8 commits into from
Dec 9, 2024

Conversation

nathanstitt
Copy link
Member

fixes a few minor issues noted noted before/during demo:

  • Researcher's study review urls used unencoded uuids
  • push instructions did not open after adding a new run
  • AWS resources were all being tagged with "Sandbox" environment and it failed with UTF chars in study title
  • Study title length was too limited
  • a tags were nested on on researcher studies listing, causing hydration errors

@nathanstitt nathanstitt requested a review from a team November 21, 2024 19:50
@nathanstitt
Copy link
Member Author

Thanks @jbwilson8 !

@nathanstitt nathanstitt merged commit 21ca403 into main Dec 9, 2024
1 check passed
@nathanstitt nathanstitt deleted the fixes-for-demo branch December 9, 2024 16:09
@jbwilson8 jbwilson8 mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbwilson8 jbwilson8 jbwilson8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanstitt @jbwilson8