Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHRIMP-20 #1

Merged
merged 2 commits into from
Oct 3, 2024
Merged

SHRIMP-20 #1

merged 2 commits into from
Oct 3, 2024

Conversation

sparksam
Copy link
Contributor

@sparksam sparksam commented Oct 3, 2024 •
edited
Loading

Ref: SHRIMP-20

Implemented

  • Possibilities to pass credentials via environment variables
  • Secure all endpoints except favicon.ico through Basic-Auth
  • Show popup if not authenticated.

@sparksam sparksam requested review from a team, nathanstitt and scb6 October 3, 2024 15:45
@sparksam sparksam marked this pull request as draft October 3, 2024 15:47
@chrisbendel chrisbendel marked this pull request as ready for review October 3, 2024 18:33
@chrisbendel chrisbendel merged commit 6a1c060 into main Oct 3, 2024
1 check failed
chrisbendel pushed a commit that referenced this pull request Jan 6, 2025
@nathanstitt
Merge pull request #1 from safeinsights/update-dependencies
1ed0ee4 
Update versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbendel chrisbendel chrisbendel approved these changes

@nathanstitt nathanstitt Awaiting requested review from nathanstitt

@scb6 scb6 Awaiting requested review from scb6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparksam @chrisbendel