Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage where missing #15

Merged
merged 29 commits into from
Dec 19, 2024
Merged

Add test coverage where missing #15

merged 29 commits into from
Dec 19, 2024

Conversation

chrisbendel
Copy link
Collaborator

No description provided.

philschatz
philschatz reviewed Dec 9, 2024
View reviewed changes
Copy link

@philschatz philschatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions about maybe using mock-fs and vitest's mock for global functions like fetch

src/app/api/run/[runId]/approve/route.test.ts Outdated Show resolved Hide resolved
src/app/api/run/[runId]/approve/route.ts Outdated Show resolved Hide resolved
src/app/api/run/[runId]/upload/route.test.ts Outdated Show resolved Hide resolved
src/app/api/run/results/route.test.ts Outdated Show resolved Hide resolved
src/app/utils.test.ts Show resolved Hide resolved
src/app/utils.ts Outdated Show resolved Hide resolved
src/middleware.test.ts Outdated Show resolved Hide resolved
src/middleware.test.ts Outdated Show resolved Hide resolved
vitest.config.mjs Outdated Show resolved Hide resolved
vitest.config.mjs Outdated Show resolved Hide resolved
@chrisbendel chrisbendel mentioned this pull request Dec 12, 2024
Merged
@chrisbendel chrisbendel marked this pull request as ready for review December 12, 2024 17:43
@chrisbendel chrisbendel requested a review from a team December 12, 2024 17:43
rnathuji
rnathuji approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@rnathuji rnathuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few minor thoughts / comments which may or may not warrant any changes depending on what you think, but in general this looks good to me.

src/app/api/run/[runId]/approve/route.test.ts Outdated Show resolved Hide resolved
src/app/utils.test.ts Outdated Show resolved Hide resolved
src/app/utils.test.ts Outdated Show resolved Hide resolved
kswanson33
kswanson33 reviewed Dec 18, 2024
View reviewed changes
Copy link

@kswanson33 kswanson33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the note on setting up config for the setup app!

vitest.config.mjs Outdated Show resolved Hide resolved
@chrisbendel chrisbendel merged commit 0ecbf66 into main Dec 19, 2024
1 check passed
@chrisbendel chrisbendel deleted the SHRMP-48-code-coverage branch December 19, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswanson33 kswanson33 kswanson33 left review comments

@philschatz philschatz philschatz left review comments

@rnathuji rnathuji rnathuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisbendel @philschatz @rnathuji @kswanson33